Remove implementation of LLVM SIMD intrinsics that are not needed anymore #4667
+35
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you for contributing to Miri! |
RalfJung
reviewed
Nov 5, 2025
src/shims/x86/avx2.rs
Outdated
| let [left, right] = | ||
| this.check_shim_sig_lenient(abi, CanonAbi::C, link_name, args)?; | ||
|
|
||
| let (which, saturating) = match unprefixed_name { |
src/shims/x86/ssse3.rs
Outdated
| let [left, right] = | ||
| this.check_shim_sig_lenient(abi, CanonAbi::C, link_name, args)?; | ||
|
|
||
| let (which, saturating) = match unprefixed_name { |
Member
There was a problem hiding this comment.
Same here, saturating is always true now.
RalfJung
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
eduardosm
force-pushed
the
remove-intrinsics
branch
from
885a2ac to
53cd5f3
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
By looking at the diff of rust-lang/stdarch#1928 and rust-lang/stdarch#1932 @rustbot ready |
rustbot
added
S-waiting-on-review
RalfJung
reviewed
Nov 6, 2025
src/shims/x86/ssse3.rs
Outdated
| }; | ||
|
|
||
| horizontal_bin_op(this, which, saturating, left, right, dest)?; | ||
| horizontal_bin_op(this, which, true /*saturating*/, left, right, dest)?; |
Member
There was a problem hiding this comment.
Suggested change
| horizontal_bin_op(this, which, true /*saturating*/, left, right, dest)?; | |
| horizontal_bin_op(this, which, /*saturating*/ true, left, right, dest)?; |
src/shims/x86/avx2.rs
Outdated
| }; | ||
|
|
||
| horizontal_bin_op(this, which, saturating, left, right, dest)?; | ||
| horizontal_bin_op(this, which, true /*saturating*/, left, right, dest)?; |
Member
There was a problem hiding this comment.
Suggested change
| horizontal_bin_op(this, which, true /*saturating*/, left, right, dest)?; | |
| horizontal_bin_op(this, which, /*saturating*/ true, left, right, dest)?; |
eduardosm
force-pushed
the
remove-intrinsics
branch
from
53cd5f3 to
57ad024
Compare
Member
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4659