Update naked to use the attribute template
#1908
Open
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To follow the attribute template, and to simplify the wording a little.
Naked attributes cannot have the "Rust" ABI. https://github.com/rust-lang/rust/blob/aae43c4532690153af7465227816c93036bb1604/compiler/rustc_passes/src/check_attr.rs#L641-L652
rustbot
added
the
S-waiting-on-review
tshepang
reviewed
Jul 11, 2025
| - [Free functions][items.fn] | ||
| - [Inherent associated functions][items.associated.fn] | ||
| - [Trait impl functions][items.impl.trait] | ||
| - [Trait definition functions][items.traits] with a body |
There was a problem hiding this comment.
does this work
Suggested change
| - [Trait definition functions][items.traits] with a body | |
| - [Trait][items.traits] [associated functions][items.associated.fn] with a body |
There was a problem hiding this comment.
This wording can be ambiguous, since it is unclear if it is an associated function in a trait definition or a trait impl. The original wording was specifically chosen to avoid that ambiguity and contrast with the previous item.
There was a problem hiding this comment.
initially wanted to link this to items.traits.associated-item-decls, due to being more specific, because items.traits was too general
- [Trait definition functions][items.traits.associated-item-decls] with a body
is that alright
|
just 1 comment, otherwise this is good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rules:
attributes.codegen.naked.syntaxattributes.codegen.naked.allowed-positionsattributes.codegen.naked.duplicatesattributes.codegen.naked.target_featureattributes.codegen.naked.abiRenamed rules:
attributes.codegen.naked.unsafe-attributeis nowattributes.codegen.naked.unsafe