get rid of const.no-mut-refs #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ehuss
added
the
S-waiting-on-stabilization
Member
Author
|
FCP passed, rust-lang/rust#148746 is in the bors queue now. |
traviscross
approved these changes
Nov 30, 2025
traviscross
removed
the
S-waiting-on-review
The rule is that "mutable references contained within a mutable static may be referenced in the final value of a constant." However, the key here is that "mutable static" means either a `static mut` item or a `static` item with an interior mutable type. We had made that clear over in `const-eval.const-expr.path-static` but not in our rules about const item validity, and our link for "mutable static" had implied it may mean `static mut`. Let's fix that and add an example to demonstrate the point.
These link reference definitions were used in `const.no-mut-refs` and are no longer needed.
traviscross
force-pushed
the
no-mut-refs
branch
from
29413ec to
b666677
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
|
I had a WIP commit to clean up the language we're about to delete. If the commit looks OK to you, I'd like to put this in the history for posterity's stake. I've stacked your commit onto it and also deleted the link reference definitions that are now unused. |
Member
Author
|
LGTM, thanks! |
bors
pushed a commit
to rust-lang/rust
that referenced
this pull request
Dec 3, 2025
Pulls in rust-lang/reference#2080 to fix the tests.
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Dec 3, 2025
Update reference Pulls in rust-lang/reference#2080 to fix the tests. Closes #149575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference PR that goes with rust-lang/rust#148746.
Fixes #2074.