update chalk, fixing trait upcasting #18944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a test asserting *incorrect* behavior that can be seen in <rust-lang#18083>, and a test asserting the *correct* behavior for the case of no super traits.
this brings in support from trait upcasting, yay! (and as such fixes a test)
rustbot
added
the
S-waiting-on-review
IIRC, I've been blocked by chalk on a couple of issues, but they are related to goal solving with associated types. But I'll check if there are any issues that can be solved with this chalk update. Thanks! |
lnicola
approved these changes
Jan 16, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chalk PR that this brings in: rust-lang/chalk#821
Fixes #18083
cc @ShoyuVanilla I've seen you involved in other trait-upcasting-related issues, maybe this unblocks something else?