fix: Use per-token, not global, edition in the parser #20163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Because, as it turns out, this is necessary to determine the correct edition (it is not global). The next commits will make use of it.
ChayimFriedman2
force-pushed
the
parser-per-token-edition
branch
2 times, most recently
from
ed6ce36 to
5736fd3
Compare
ChayimFriedman2
force-pushed
the
parser-per-token-edition
branch
from
5736fd3 to
9bc940a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns out to not mitigate #20153, because it was not the real reason. The real reason even has a FIXME:
rust-analyzer/crates/mbe/src/lib.rs
Lines 372 to 373 in 8b53dd0
But it still should fix some small bug that only appears on edition 2015. I didn't write a test because I'm not sure under what conditions it'll manifest, but it should be there.