Skip to content

Migrate remaining SourceChangeBuilder::replace of convert_match_to_let_else #20226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Migrate remaining SourceChangeBuilder::replace of convert_match_to_let_else #20226

wants to merge 1 commit into from

Conversation

Hmikihiro
Copy link
Contributor

@Hmikihiro Hmikihiro commented Jul 10, 2025 •
edited
Loading

follow up #20218

  • Migrated the remaining calls to SourceChangeBuilder::replace to use the SyntaxEditor
  • Replaced usage of format! for AST generation with SyntaxFactory methods

It seems that with the current replacement, indentation is not preserved, so it may be necessary to migrate IndentLevel::increase_indent first.

@ShoyuVanilla
Copy link
Member

It seems that with the current replacement, indentation is not preserved, so it may be necessary to migrate IndentLevel::increase_indent first.

Oh, I'll take a look on it this weekend

@ShoyuVanilla ShoyuVanilla mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hmikihiro @ShoyuVanilla