Clippify, and hide some lints in test output #3003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happy clippy = happy developers The test expectations generate a bunch of lints that are mostly irrelevant, at least at the moment, so might as well record them to avoid `cargo clippy` from reporting them.
emilio
approved these changes
Nov 30, 2024
Contributor
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
Totally fine but I don't think we should be linting our test expectations necessarily...
Contributor
Author
|
@emilio we shouldn't lint the test results - I agree, but we also shouldn't generate the code that linter complains about... or at least minimize those complains - i.e. the generated code should confirm to at least some of the same standards as the developers :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy clippy = happy developers
The test expectations generate a bunch of lints that are mostly irrelevant, at least at the moment, so might as well record them to avoid
cargo clippyfrom reporting them.