Mangle identifiers named 'gen' now that it's a reserved keyword #3100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Feb 1, 2025
This was referenced Feb 27, 2025
eeeebbbbrrrr
added a commit
to eeeebbbbrrrr/pgrx
that referenced
this pull request
Mar 17, 2025
This is necessary in order for `rustfmt` to understand our (relatively-new) usages of rust `c"C Strings"`. However, the word `gen` has been promoted to a keyword in 2024 edition, which borks `rustfmt` in a different way. Fixing this requires that we have a version of bindgen with rust-lang/rust-bindgen#3100, which, of course, has not been released yet. So I don't know where to go next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #3093