ci/release: Ubuntu 20.04 being sunset #3218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onkoe
reviewed
Jun 7, 2025
.github/workflows/release.yml
Outdated
| # Run 'cargo dist plan' (or host) to determine what tasks we need to do | ||
| plan: | ||
| runs-on: "ubuntu-20.04" | ||
| runs-on: "ubuntu-latest" |
There was a problem hiding this comment.
ubuntu-latest is often a bad idea - you're kinda begging for CI to fail due to something that isn't your fault. D:
Could you please consider using 22.04 or 24.04 instead?
Contributor
Author
There was a problem hiding this comment.
Yeah no problem, in this specific case using latest would've not broken though. As old versions will eventually be decommissioned.
There was a problem hiding this comment.
That's true! Still, I think a PR every few years to update the version is just fine.
NickeZ
force-pushed
the
nickez/ubuntu-20.04-sunset
branch
from
1c08ddd to
da2a72d
Compare
Replace 20.04 with latest
NickeZ
force-pushed
the
nickez/ubuntu-20.04-sunset
branch
from
da2a72d to
a346aff
Compare
onkoe
approved these changes
Jun 7, 2025
onkoe
left a comment
onkoe
left a comment
There was a problem hiding this comment.
looks good! I'm not a maintainer by the way - this PR just kinda caught my eye.
hope it gets merged soon! ;D
emilio
approved these changes
Jun 8, 2025
Contributor
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
lgtm, thanks for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace 20.04 with latest