Refactor item_name method to use ItemInfo struct #3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
force-pushed
the
item-kind-to-item-name
branch
from
6525e65 to
dc2a5c4
Compare
MarijnS95
reviewed
Jun 11, 2025
Comment on lines
+293
to
295
| #[derive(Clone, Copy)] | ||
| #[non_exhaustive] | ||
| pub enum ItemKind { |
There was a problem hiding this comment.
Should this have had the common Debug, PartialEq, Eq, Hash derives as well, just like #3055?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.