Skip to content

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 21, 2025

Based on #13084

The disallow_span_lint test is removed since it depends on a clippy.toml from outside the test directory. This causes ui_test to be unable to normalize the path (see ci failure).

changelog: [disallowed_*][await_holding_invalid]: Note the config span the first time an invalid item is used.

Jarcho added 2 commits April 20, 2025 21:54
* More precise spans in diagnostics
* Allow multiple diagnostics for each config value
* Ability to capture spans in the parsed config
* Easier support of `..` in lists
* Remove `clippy_utils` dependancy from `clippy_config`
* Multi-column support for long suggestion lists
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 21, 2025
@Jarcho Jarcho changed the title Disallowed span Add a note for disallowed items referring to the config file Apr 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2025

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants