-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Soft rename clippy::all
to clippy::default
#14689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,11 @@ | |||
// Tests that `clippy::all` still works without a deprecation warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to intrude, but why don't you want a deprecation warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's starting as a soft deprecation since it's very widely used, it may eventually become a warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not deprecate it. I don't think it is ever worth to do so. I think clippy::all
is older than 5 years by now. It will take at least the same amount of time until clippy::default
is used in more places than clippy::all
, I would think. So maybe really really long-term, we can deprecate it. But that might even be the decision of a different set of people by then.
Plus, I don't see any downsides in keeping it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Giving @rust-lang/clippy @rust-lang/clippy-contributors until the end of the week to still raise concerns (as there's no going back realistically). But I think everyone is on-board with this.
This comment has been minimized.
This comment has been minimized.
Ping @Alexendoo this needs a rebase. I don't think any objections were raised. |
0a70aea
to
a033f84
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Lintcheck changes for a033f84
This comment will be updated if you push new changes |
r? @flip1995
For now I haven't updated the docs since people read the current README/etc for stable usage
changelog:
clippy::all
has been renamed toclippy::default
, existing uses ofclippy::all
do not need to be changed