Skip to content

Do not specialize for if_chain any longer #15362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

samueltardieu
Copy link
Member

Now that if let chains have been introduced, the if_chain external crate is no longer necessary. Dropping special support for it also alleviates the need to keep the crate as a dependency in tests.

This is a cleanup PR.

changelog: none

Now that `if let` chains have been introduced, the `if_chain` external
crate is no longer necessary. Dropping special support for it also
alleviates the need to keep the crate as a dependency in tests.
@rustbot
Copy link
Collaborator

rustbot commented Jul 28, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 28, 2025
@samueltardieu
Copy link
Member Author

Likely no new crate will depend on if_chain, old crates have been linted already, and the if_chain crate has not been updated for four years.

@dswij dswij added this pull request to the merge queue Aug 1, 2025
Merged via the queue into rust-lang:master with commit 94b7035 Aug 1, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 1, 2025
@samueltardieu samueltardieu deleted the drop-if-chain-dependency branch August 2, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants