Skip to content

Output lintcheck summary HTML markdown in order #15371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Output lintcheck summary HTML markdown in order #15371

merged 1 commit into from
Jul 31, 2025

Conversation

samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Jul 30, 2025 •
edited by rustbot
Loading

The data in the table needs to be in the same order as the headings.

changelog: none

Fixes #15370

@samueltardieu
Output lintcheck summary HTML markdown in order
c578762 
The data in the table needs to be in the same order as the headings.
@rustbot
Copy link
Collaborator

rustbot commented Jul 30, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 30, 2025
blyxyas
blyxyas approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️ Curious how the lintcheck comment was written correctly but the summary outputed to GHA was not.

@blyxyas blyxyas added this pull request to the merge queue Jul 31, 2025
Merged via the queue into rust-lang:master with commit fab7eab Jul 31, 2025
11 of 13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 31, 2025
@samueltardieu samueltardieu deleted the issue-15370 branch July 31, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lintcheck outputs fields in wrong order
3 participants
@samueltardieu @rustbot @blyxyas