std: sys: net: uefi: tcp4: Implement write #141532

Ayush1325 · 2025-05-25T06:53:09Z

A blocking implementation of tcp4 write.

rustbot · 2025-05-25T06:53:14Z

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Ayush1325 · 2025-06-15T12:30:41Z

@rustbot label +O-UEFI

tgross35

A few nits but this looks reasonable to me. @nicholasbishop would you mind double checking since this is UEFI?

tgross35 · 2025-07-01T09:14:24Z

library/std/src/sys/net/connection/uefi/tcp4.rs

+        let protocol = self.protocol.as_ptr();
+        let mut token = tcp4::IoToken {
+            completion_token,
+            packet: tcp4::IoTokenPacket { tx_data: &mut tx_data as *mut _ as *mut _ },


packet: tcp4::IoTokenPacket { tx_data: ptr::from_mut(&mut tx_data).cast::<whatever>() },

What casts are needed? tx_data should be tcp4::TransmitData, and that looks like what is expected in https://docs.rs/r-efi/latest/r_efi/protocols/tcp4/union.IoTokenPacket.html.

Also, isn't rx_data missing?

What casts are needed? tx_data should be tcp4::TransmitData, and that looks like what is expected in https://docs.rs/r-efi/latest/r_efi/protocols/tcp4/union.IoTokenPacket.html.

Well, tcp4::TransmitData is a const generic. tcp4::IoTokenPacket takes ZST (tcp4::TransmitData<0>). So we are casting tcp4::TransmitData<1> to tcp4::TransmitData<0>.

Also, isn't rx_data missing?

It's a union.

tgross35 · 2025-07-01T09:14:29Z

library/std/src/sys/net/connection/uefi/tcp4.rs

+
+        let fragment = tcp4::FragmentData {
+            fragment_length: data_len,
+            fragment_buffer: buf.as_ptr() as *mut _,


Nit to make the cast obvious (especially since it includes a mutability change)

fragment_buffer: buf.as_ptr().cast::<c_void>().cast_mut()

nicholasbishop · 2025-07-03T17:23:59Z

library/std/src/sys/net/connection/uefi/mod.rs

-    pub fn write_vectored(&self, _: &[IoSlice<'_>]) -> io::Result<usize> {
-        unsupported()
+    pub fn write_vectored(&self, buf: &[IoSlice<'_>]) -> io::Result<usize> {
+        // FIXME: UEFI does support vectored write, so implment that.


implment -> implement

nicholasbishop · 2025-07-03T17:48:42Z

library/std/src/sys/net/connection/uefi/tcp4.rs

+        let evt = unsafe { self.create_evt() }?;
+        let completion_token =
+            tcp4::CompletionToken { event: evt.as_ptr(), status: Status::SUCCESS };
+        let data_len = crate::cmp::min(u32::MAX as u64, buf.len() as u64) as u32;


Am I reading correctly that this is truncating the buffer length to a u32? If so, might be clearer as:

let data_len = u32::try_from(buf.len()).unwrap_or(u32::MAX);

nicholasbishop · 2025-07-03T17:54:42Z

library/std/src/sys/net/connection/uefi/tcp4.rs

+        let mut token = tcp4::IoToken {
+            completion_token,
+            packet: tcp4::IoTokenPacket {
+                tx_data: &mut tx_data as *mut tcp4::TransmitData<1> as *mut tcp4::TransmitData,


I think this casting could be simplified:

tx_data: (&raw mut tx_data).cast::<tcp4::TransmitData<0>>(),

A blocking implementation of tcp4 write. Signed-off-by: Ayush Singh <[email protected]>

tgross35

Thanks!

tgross35 · 2025-07-04T19:04:34Z

@bors r+ rollup

bors · 2025-07-04T19:04:38Z

📌 Commit f4ef1a7 has been approved by tgross35

It is now in the queue for this repository.

std: sys: net: uefi: tcp4: Implement write A blocking implementation of tcp4 write.

Rollup of 9 pull requests Successful merges: - #141532 (std: sys: net: uefi: tcp4: Implement write) - #143085 (Port `#[non_exhaustive]` to the new attribute parsing infrastructure) - #143298 (`tests/ui`: A New Order [23/N]) - #143372 (Remove names_imported_by_glob_use query.) - #143386 (Assign dependency bump PRs to me) - #143406 (Remove some unnecessary `unsafe` in VecCache) - #143408 (mbe: Gracefully handle macro rules that end after `=>`) - #143414 (remove special-casing of boxes from match exhaustiveness/usefulness analysis) - #143444 (clean up GVN TypeId test) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - #141532 (std: sys: net: uefi: tcp4: Implement write) - #143085 (Port `#[non_exhaustive]` to the new attribute parsing infrastructure) - #143372 (Remove names_imported_by_glob_use query.) - #143386 (Assign dependency bump PRs to me) - #143406 (Remove some unnecessary `unsafe` in VecCache) - #143408 (mbe: Gracefully handle macro rules that end after `=>`) - #143414 (remove special-casing of boxes from match exhaustiveness/usefulness analysis) - #143444 (clean up GVN TypeId test) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141532 - Ayush1325:uefi-tcp4-send, r=tgross35 std: sys: net: uefi: tcp4: Implement write A blocking implementation of tcp4 write.

rustbot assigned thomcc May 25, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 25, 2025

Ayush1325 mentioned this pull request Jun 1, 2025

Tracking Issue for uefi-std #100499

Open

rustbot added the O-UEFI UEFI label Jun 15, 2025

tgross35 reviewed Jul 1, 2025

View reviewed changes

tgross35 assigned tgross35 and unassigned thomcc Jul 1, 2025

Ayush1325 force-pushed the uefi-tcp4-send branch from 8256b6d to 42a8444 Compare July 2, 2025 16:51

nicholasbishop reviewed Jul 3, 2025

View reviewed changes

std: sys: net: uefi: tcp4: Implement write

f4ef1a7

A blocking implementation of tcp4 write. Signed-off-by: Ayush Singh <[email protected]>

Ayush1325 force-pushed the uefi-tcp4-send branch from 42a8444 to f4ef1a7 Compare July 4, 2025 16:23

tgross35 approved these changes Jul 4, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 4, 2025

Rollup merge of rust-lang#141532 - Ayush1325:uefi-tcp4-send, r=tgross35

34e5603

std: sys: net: uefi: tcp4: Implement write A blocking implementation of tcp4 write.

matthiaskrgr mentioned this pull request Jul 4, 2025

Rollup of 9 pull requests #143454

Closed

matthiaskrgr mentioned this pull request Jul 4, 2025

Rollup of 8 pull requests #143459

Merged

bors merged commit edfaaeb into rust-lang:master Jul 5, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 5, 2025

rust-timer added a commit that referenced this pull request Jul 5, 2025

Unrolled build for #141532

4f7e514

Rollup merge of #141532 - Ayush1325:uefi-tcp4-send, r=tgross35 std: sys: net: uefi: tcp4: Implement write A blocking implementation of tcp4 write.

Ayush1325 deleted the uefi-tcp4-send branch July 5, 2025 02:41

Ayush1325 mentioned this pull request Jul 5, 2025

std: sys: net: uefi: tcp4: Implement read #143470

Open

std: sys: net: uefi: tcp4: Implement write #141532

std: sys: net: uefi: tcp4: Implement write #141532

Conversation

Ayush1325 commented May 25, 2025

Uh oh!

rustbot commented May 25, 2025

Uh oh!

Ayush1325 commented Jun 15, 2025

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ayush1325 Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Jul 4, 2025

Uh oh!

bors commented Jul 4, 2025

Uh oh!

Uh oh!

Uh oh!

Ayush1325 Jul 2, 2025 •

edited

Loading