rust: library: Add `setsid` method to `CommandExt` trait #142391

LevitatingBusinessMan · 2025-06-12T00:43:48Z

Add a setsid method to the CommandExt trait so that callers can create a process in a new session and process group whilst still using the POSIX spawn fast path.

Tracking issue: #105376

ACP: rust-lang/libs-team#184

This PR was previously submitted by @HarveyHunt (whom I marked as Co-Author in the commit message) in #105377. However that PR went stale.

I applied the suggestion to change the function signature to fn setsid(&mut self, setsid: bool) -> &mut Command.

rustbot · 2025-06-12T00:43:53Z

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

LevitatingBusinessMan · 2025-06-12T00:44:31Z

@rustbot label +T-libs-api -T-libs

rustbot · 2025-06-13T11:42:28Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- 8285fe4

workingjubilee · 2025-07-01T18:49:44Z

this doesn't finish building so I don't know what I should be reviewing?

LevitatingBusinessMan · 2025-07-01T19:20:20Z

It appears only Linux supports libc::POSIX_SPAWN_SETSID, so the compilation fails on other systems. I am still contemplating the best way to fix this.

I guess it should use the exec+fork method instead when setsid is set and the os is not linux?

I am also kind of confused as to why compilation didn't fail in the previous PR.

workingjubilee · 2025-07-01T19:46:59Z

We have significantly adjusted what we test in "PR CI", the subset of tests we run on every open PR against rust-lang/rust.

workingjubilee · 2025-07-01T19:48:09Z

also there is a nightly os::linux::process::CommandExt https://doc.rust-lang.org/std/os/linux/process/trait.CommandExt.html

workingjubilee · 2025-07-04T22:46:26Z

@rustbot author

rustbot · 2025-07-04T22:46:30Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Add a setsid method to the CommandExt trait so that callers can create a process in a new session and process group whilst still using the POSIX spawn fast path. Co-Authored-By: Harvey Hunt <[email protected]>

LevitatingBusinessMan · 2025-07-10T04:46:09Z

@rustbot ready

workingjubilee · 2025-07-10T22:05:03Z

Sure, this seems fine as a nightly impl. We should mention the libc issue in the tracking issue.

@bors r+

bors · 2025-07-10T22:05:06Z

📌 Commit e0f7687 has been approved by workingjubilee

It is now in the queue for this repository.

workingjubilee · 2025-07-10T22:05:09Z

@bors rollup

…rkingjubilee rust: library: Add `setsid` method to `CommandExt` trait Add a setsid method to the CommandExt trait so that callers can create a process in a new session and process group whilst still using the POSIX spawn fast path. Tracking issue: rust-lang#105376 ACP: rust-lang/libs-team#184 This PR was previously submitted by `@HarveyHunt` (whom I marked as Co-Author in the commit message) in rust-lang#105377. However that PR went stale. I applied the [suggestion](https://github.com/rust-lang/rust/pull/105377/files/231d19fcbfe155b2e85116865adae4253380ff1f#r1893457943) to change the function signature to `fn setsid(&mut self, setsid: bool) -> &mut Command`.

Rollup of 7 pull requests Successful merges: - #142391 (rust: library: Add `setsid` method to `CommandExt` trait) - #143301 (`tests/ui`: A New Order [26/N]) - #143302 (`tests/ui`: A New Order [27/N]) - #143303 (`tests/ui`: A New Order [28/28] FINAL PART) - #143568 (std: sys: net: uefi: tcp4: Add timeout support) - #143708 (fix: Include frontmatter in -Zunpretty output ) - #143718 (Make UB transmutes really UB in LLVM) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - #142391 (rust: library: Add `setsid` method to `CommandExt` trait) - #143302 (`tests/ui`: A New Order [27/N]) - #143303 (`tests/ui`: A New Order [28/28] FINAL PART) - #143568 (std: sys: net: uefi: tcp4: Add timeout support) - #143611 (Mention more APIs in `ParseIntError` docs) - #143661 (chore: Improve how the other suggestions message gets rendered) - #143708 (fix: Include frontmatter in -Zunpretty output ) - #143718 (Make UB transmutes really UB in LLVM) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - #142391 (rust: library: Add `setsid` method to `CommandExt` trait) - #143302 (`tests/ui`: A New Order [27/N]) - #143303 (`tests/ui`: A New Order [28/28] FINAL PART) - #143568 (std: sys: net: uefi: tcp4: Add timeout support) - #143611 (Mention more APIs in `ParseIntError` docs) - #143661 (chore: Improve how the other suggestions message gets rendered) - #143708 (fix: Include frontmatter in -Zunpretty output ) - #143718 (Make UB transmutes really UB in LLVM) r? `@ghost` `@rustbot` modify labels: rollup try-job: i686-gnu-nopt-1 try-job: test-various

Rollup merge of #142391 - LevitatingBusinessMan:setsid, r=workingjubilee rust: library: Add `setsid` method to `CommandExt` trait Add a setsid method to the CommandExt trait so that callers can create a process in a new session and process group whilst still using the POSIX spawn fast path. Tracking issue: #105376 ACP: rust-lang/libs-team#184 This PR was previously submitted by ``@HarveyHunt`` (whom I marked as Co-Author in the commit message) in #105377. However that PR went stale. I applied the [suggestion](https://github.com/rust-lang/rust/pull/105377/files/231d19fcbfe155b2e85116865adae4253380ff1f#r1893457943) to change the function signature to `fn setsid(&mut self, setsid: bool) -> &mut Command`.

rustbot assigned workingjubilee Jun 12, 2025

rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 12, 2025

This comment has been minimized.

Sign in to view

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 12, 2025

This comment has been minimized.

Sign in to view

LevitatingBusinessMan force-pushed the setsid branch from 61ae756 to 8285fe4 Compare June 13, 2025 11:42

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025

LevitatingBusinessMan force-pushed the setsid branch from 8285fe4 to 4758234 Compare July 10, 2025 03:17

rust: library: Add setsid method to CommandExt trait

e0f7687

Add a setsid method to the CommandExt trait so that callers can create a process in a new session and process group whilst still using the POSIX spawn fast path. Co-Authored-By: Harvey Hunt <[email protected]>

LevitatingBusinessMan force-pushed the setsid branch from 4758234 to e0f7687 Compare July 10, 2025 03:27

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2025

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2025

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 10, 2025

workingjubilee mentioned this pull request Jul 22, 2023

Tracking Issue for process_setsid #105376

Open

3 tasks

tgross35 mentioned this pull request Jul 10, 2025

Rollup of 7 pull requests #143760

Closed

matthiaskrgr mentioned this pull request Jul 11, 2025

Rollup of 8 pull requests #143766

Merged

bors merged commit 2730beb into rust-lang:master Jul 12, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rust: library: Add `setsid` method to `CommandExt` trait #142391

rust: library: Add `setsid` method to `CommandExt` trait #142391

LevitatingBusinessMan commented Jun 12, 2025 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jun 12, 2025

Uh oh!

This comment has been minimized.

LevitatingBusinessMan commented Jun 12, 2025

Uh oh!

This comment has been minimized.

rustbot commented Jun 13, 2025

Uh oh!

This comment has been minimized.

workingjubilee commented Jul 1, 2025

Uh oh!

LevitatingBusinessMan commented Jul 1, 2025 •

edited

Loading

Uh oh!

workingjubilee commented Jul 1, 2025

Uh oh!

workingjubilee commented Jul 1, 2025

Uh oh!

workingjubilee commented Jul 4, 2025

Uh oh!

rustbot commented Jul 4, 2025

Uh oh!

LevitatingBusinessMan commented Jul 10, 2025

Uh oh!

workingjubilee commented Jul 10, 2025

Uh oh!

bors commented Jul 10, 2025

Uh oh!

workingjubilee commented Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

rust: library: Add setsid method to CommandExt trait #142391

rust: library: Add setsid method to CommandExt trait #142391

Conversation

LevitatingBusinessMan commented Jun 12, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 12, 2025

Uh oh!

This comment has been minimized.

LevitatingBusinessMan commented Jun 12, 2025

Uh oh!

This comment has been minimized.

rustbot commented Jun 13, 2025

Uh oh!

This comment has been minimized.

workingjubilee commented Jul 1, 2025

Uh oh!

LevitatingBusinessMan commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

workingjubilee commented Jul 1, 2025

Uh oh!

workingjubilee commented Jul 1, 2025

Uh oh!

workingjubilee commented Jul 4, 2025

Uh oh!

rustbot commented Jul 4, 2025

Uh oh!

LevitatingBusinessMan commented Jul 10, 2025

Uh oh!

workingjubilee commented Jul 10, 2025

Uh oh!

bors commented Jul 10, 2025

Uh oh!

workingjubilee commented Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

rust: library: Add `setsid` method to `CommandExt` trait #142391

rust: library: Add `setsid` method to `CommandExt` trait #142391

LevitatingBusinessMan commented Jun 12, 2025 •

edited by rustbot

Loading

LevitatingBusinessMan commented Jul 1, 2025 •

edited

Loading