`tests/ui`: A New Order [27/N] #143302

Kivooeo · 2025-07-01T19:43:23Z

Note

Intermediate commits are intended to help review, but will be squashed prior to merge.

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

r? @tgross35

tgross35

I might have a couple other comments too but the GH UI is giving me some problems with the diff. Could you squash?

tests/ui/auto-traits/auto-traits-type-parameter

tests/ui/lifetimes/any-lifetime-escape-higher-rank.rs

tests/ui/limits/type-length-limit-enforcement.rs

tgross35 · 2025-07-04T20:47:26Z

tests/ui/try-trait/try-operator-expansion-hygiene.rs

-// `expr?` expands to:
-//
-// match expr {
-//     Ok(val) => val,
-//     Err(err) => return Err(From::from(err)),
-// }
-//
-// This test verifies that the expansion is hygienic, i.e., it's not affected by other `val` and
-// `err` bindings that may be in scope.


Why is this deleted?

AFAIK, it's not true anymore, it expands into this https://doc.rust-lang.org/std/ops/trait.Try.html#tymethod.branch

like this

match maybe_err.branch() { ControlFlow::Continue(r) => r, ControlFlow::Break(e) => return Result::from_residual(e), }

Also if it'll help to you invistigation what is going here, here is a discussion about it #84277 (comment)

Thanks for the links, looks like this was added in 210dd61. Maybe update the description to say "Ensure that bindings named val and err do not affect ? expansion (mostly relevant with a previous implementation for ?)."

tests/ui/type/typeid-consistency-comprehensive.rs

tests/ui/type-inference/type-inference-none-in-generic-ref.rs

Kivooeo

I squashed commits, but still have some questions

Kivooeo · 2025-07-04T21:08:26Z

tests/ui/limits/type-length-limit-enforcement.rs

@@ -1,17 +1,17 @@
-//@ build-fail


Just drop it like this with no any addition?

Yeah - the default is check-fail, and I'm thinking that is fine here since we're testing frontend diagnostics. We prefer that because it's cheap+fast (no codegen required). build-fail is used for things that are expected to fail later, like linking problems.

Some more info at https://rustc-dev-guide.rust-lang.org/tests/ui.html#controlling-passfail-expectations

Test is not passing if i remove build-fail, so... I guess we should keep it

tgross35

One , nit and an update in the try-operator-expansion-hygiene comment, then lgtm

tgross35 · 2025-07-09T23:22:25Z

tests/ui/auto-traits/auto-traits-type-parameter.rs

+//! Checks how type parameters interact with auto-traits like `Send` and `Sync` with implicit,
+//! bounds


Suggested change

//! Checks how type parameters interact with auto-traits like `Send` and `Sync` with implicit,

//! bounds

//! Checks how type parameters interact with auto-traits like `Send` and `Sync` with implicit

//! bounds

extra comma

tgross35 · 2025-07-09T23:55:15Z

tests/ui/try-trait/try-operator-expansion-hygiene.rs

-// `expr?` expands to:
-//
-// match expr {
-//     Ok(val) => val,
-//     Err(err) => return Err(From::from(err)),
-// }
-//
-// This test verifies that the expansion is hygienic, i.e., it's not affected by other `val` and
-// `err` bindings that may be in scope.


Thanks for the links, looks like this was added in 210dd61. Maybe update the description to say "Ensure that bindings named val and err do not affect ? expansion (mostly relevant with a previous implementation for ?)."

Kivooeo · 2025-07-10T15:25:48Z

@rustbot ready

tgross35

Thanks!

tgross35 · 2025-07-10T21:44:22Z

@bors r+ rollup

bors · 2025-07-10T21:44:26Z

📌 Commit 3ad95cc has been approved by tgross35

It is now in the queue for this repository.

`tests/ui`: A New Order [27/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? `@tgross35`

Rollup of 7 pull requests Successful merges: - #142391 (rust: library: Add `setsid` method to `CommandExt` trait) - #143301 (`tests/ui`: A New Order [26/N]) - #143302 (`tests/ui`: A New Order [27/N]) - #143303 (`tests/ui`: A New Order [28/28] FINAL PART) - #143568 (std: sys: net: uefi: tcp4: Add timeout support) - #143708 (fix: Include frontmatter in -Zunpretty output ) - #143718 (Make UB transmutes really UB in LLVM) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - #142391 (rust: library: Add `setsid` method to `CommandExt` trait) - #143302 (`tests/ui`: A New Order [27/N]) - #143303 (`tests/ui`: A New Order [28/28] FINAL PART) - #143568 (std: sys: net: uefi: tcp4: Add timeout support) - #143611 (Mention more APIs in `ParseIntError` docs) - #143661 (chore: Improve how the other suggestions message gets rendered) - #143708 (fix: Include frontmatter in -Zunpretty output ) - #143718 (Make UB transmutes really UB in LLVM) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - #142391 (rust: library: Add `setsid` method to `CommandExt` trait) - #143302 (`tests/ui`: A New Order [27/N]) - #143303 (`tests/ui`: A New Order [28/28] FINAL PART) - #143568 (std: sys: net: uefi: tcp4: Add timeout support) - #143611 (Mention more APIs in `ParseIntError` docs) - #143661 (chore: Improve how the other suggestions message gets rendered) - #143708 (fix: Include frontmatter in -Zunpretty output ) - #143718 (Make UB transmutes really UB in LLVM) r? `@ghost` `@rustbot` modify labels: rollup try-job: i686-gnu-nopt-1 try-job: test-various

Rollup merge of #143302 - Kivooeo:tf27, r=tgross35 `tests/ui`: A New Order [27/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of #133895. r? ``@tgross35``

moved tests

e9191ec

rustbot assigned tgross35 Jul 1, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 1, 2025

This comment has been minimized.

Sign in to view

tgross35 requested changes Jul 4, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025

Kivooeo force-pushed the tf27 branch from 81b5b2b to 7c60e37 Compare July 4, 2025 21:03

Kivooeo commented Jul 4, 2025

View reviewed changes

Kivooeo force-pushed the tf27 branch from 7c60e37 to 872f62f Compare July 4, 2025 21:18

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the tf27 branch from 872f62f to 704ab11 Compare July 4, 2025 22:09

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the tf27 branch from 704ab11 to 76bbef0 Compare July 5, 2025 00:22

tgross35 reviewed Jul 9, 2025

View reviewed changes

cleaned up some tests

3ad95cc

Kivooeo force-pushed the tf27 branch from 76bbef0 to 3ad95cc Compare July 10, 2025 13:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2025

tgross35 approved these changes Jul 10, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2025

tgross35 mentioned this pull request Jul 10, 2025

Rollup of 7 pull requests #143760

Closed

matthiaskrgr mentioned this pull request Jul 11, 2025

Rollup of 8 pull requests #143766

Merged

bors merged commit 3d6eb22 into rust-lang:master Jul 12, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 12, 2025

		//! Checks how type parameters interact with auto-traits like `Send` and `Sync` with implicit,
		//! bounds

tests/ui: A New Order [27/N] #143302

tests/ui: A New Order [27/N] #143302

Uh oh!

Conversation

Kivooeo commented Jul 1, 2025

Uh oh!

This comment has been minimized.

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kivooeo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Jul 10, 2025

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Jul 10, 2025

Uh oh!

bors commented Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

`tests/ui`: A New Order [27/N] #143302

`tests/ui`: A New Order [27/N] #143302