Port streaming commands in bootstrap to BootstrapCommand and remove as_command_mut
#143354
+85
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-bootstrap
This comment has been minimized.
This comment has been minimized.
Shourya742
force-pushed
the
2025-07-03-bye-bye-as_mut-command
branch
from
57f20c5 to
868ef64
Compare
This comment has been minimized.
This comment has been minimized.
Kobzol
reviewed
Jul 4, 2025
|
|
||
| /// Spawn the command in background, while capturing and returning stdout, and printing stderr. | ||
| #[track_caller] | ||
| pub fn stream_capture_stdout( |
There was a problem hiding this comment.
We only need stream_capture_stdout right now, right? So we can remove stream_capture. Reading both stdout and stderr in a streaming fashion while avoiding deadlocks is relatively complicated anyway, and we don't need it currently in bootstrap.
There was a problem hiding this comment.
Looks like the stream_capture method is still there?
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Shourya742
force-pushed
the
2025-07-03-bye-bye-as_mut-command
branch
from
64ac851 to
03c7625
Compare
Kobzol
reviewed
Jul 4, 2025
Kobzol
changed the title
BootstrapCommand and remove as_command_mut
Kobzol
reviewed
Jul 4, 2025
Shourya742
force-pushed
the
2025-07-03-bye-bye-as_mut-command
branch
2 times, most recently
from
ee110a1 to
216ef55
Compare
Shourya742
force-pushed
the
2025-07-03-bye-bye-as_mut-command
branch
from
216ef55 to
c4fae7c
Compare
This comment has been minimized.
This comment has been minimized.
Shourya742
force-pushed
the
2025-07-03-bye-bye-as_mut-command
branch
from
c4fae7c to
536d15a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds streaming capabilities to BootstrapCommand and migrate existing command streaming scenario's used in bootstrap.
r? @Kobzol