Use relative visibility when noting sealed trait to reduce false positive #143431
+48
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <[email protected]>
…tive Signed-off-by: xizheyin <[email protected]>
rustbot
added
S-waiting-on-review
xizheyin
changed the title
compiler-errors
requested changes
Jul 4, 2025
| let ty = trait_pred.self_ty(); | ||
| if let Some(id) = ty.def_id_for_ty_in_cycle() { | ||
| let is_locally_reachable = tcx.parent(def_id).is_crate_root(); | ||
| let vis: &rustc_middle::middle::privacy::EffectiveVisibilities = |
There was a problem hiding this comment.
This type ascription isn't needed.
| let is_locally_reachable = tcx.parent(def_id).is_crate_root(); | ||
| vis.is_reachable(local) || is_locally_reachable | ||
| let ty = trait_pred.self_ty(); | ||
| if let Some(id) = ty.def_id_for_ty_in_cycle() { |
There was a problem hiding this comment.
You should be matching on the tykind here, rather than using def_id_for_ty_in_cycle. Doesn't it seem weird that you're using a function with that name? 😅
| if let Some(id) = ty.def_id_for_ty_in_cycle() { | ||
| let is_locally_reachable = tcx.parent(def_id).is_crate_root(); | ||
| let vis: &rustc_middle::middle::privacy::EffectiveVisibilities = | ||
| &tcx.resolutions(()).effective_visibilities; |
There was a problem hiding this comment.
effective_visibilities is exposed through its own query, so using resolutions(()).effective_visibilities is less efficient.
| let vis: &rustc_middle::middle::privacy::EffectiveVisibilities = | ||
| &tcx.resolutions(()).effective_visibilities; | ||
| let is_reachable = vis.effective_vis(local).is_some_and(|v| { | ||
| v.at_level(rustc_middle::middle::privacy::Level::Reachable) |
| v.at_level(rustc_middle::middle::privacy::Level::Reachable) | ||
| .is_accessible_from(id, tcx) | ||
| }); | ||
| is_reachable || is_locally_reachable |
There was a problem hiding this comment.
This logic seems subtle, and so at least needs a comment. Also, I may be wrong, but isn't locally_reachable implied by reachable?
| let is_locally_reachable = tcx.parent(def_id).is_crate_root(); | ||
| vis.is_reachable(local) || is_locally_reachable | ||
| let ty = trait_pred.self_ty(); | ||
| if let Some(id) = ty.def_id_for_ty_in_cycle() { |
There was a problem hiding this comment.
Also, please give id a better name; we already have def_id in scope.
compiler-errors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143392
I used relative visibility instead of just determining if it's public or not.
r? compiler