Skip to content

move va_copy, va_arg and va_end to core::intrinsics #143445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2025
Merged

move va_copy, va_arg and va_end to core::intrinsics #143445

merged 1 commit into from
Jul 5, 2025
+24 −17

Conversation

folkertdev
Copy link
Contributor

some questions:

  • should these functions be pub?
  • is a separate module justified?

r? @RalfJung

@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2025

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 4, 2025
@folkertdev folkertdev changed the title move the va_copy, va_arg and va_end to core::intrinsics move va_copy, va_arg and va_end to core::intrinsics Jul 4, 2025
@RalfJung
Copy link
Member

RalfJung commented Jul 4, 2025

should these functions be pub?

Yes, like all intrinsics.

is a separate module justified?

If the types stay where they are (which seems reasonable), then I don't think we need a separate module for 3 functions.

@RalfJung
Copy link
Member

RalfJung commented Jul 4, 2025

Also, while at it, can you add /// FIXME: document safety requirements to all of them?

@RalfJung
Copy link
Member

RalfJung commented Jul 4, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@folkertdev folkertdev force-pushed the va-list-intrinsics branch from aa2a5bf to 4ae22fb Compare July 5, 2025 08:32
@folkertdev
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2025
@RalfJung
Copy link
Member

RalfJung commented Jul 5, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 5, 2025

📌 Commit 4ae22fb has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2025
@saethlin saethlin mentioned this pull request Jul 5, 2025
Merged
bors added a commit that referenced this pull request Jul 5, 2025
@bors
Auto merge of #143496 - saethlin:rollup-4u43rgj, r=saethlin
175e043 
Rollup of 3 pull requests

Successful merges:

 - #143291 (codegen_ssa: replace a Result by an Either)
 - #143445 (move `va_copy`, `va_arg` and `va_end` to `core::intrinsics`)
 - #143447 ([COMPILETEST-UNTANGLE 4/N] Improve compiletest config documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7245feb into rust-lang:master Jul 5, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 5, 2025
rust-timer added a commit that referenced this pull request Jul 5, 2025
@rust-timer
Unrolled build for #143445
21c6f7b 
Rollup merge of #143445 - folkertdev:va-list-intrinsics, r=RalfJung

move `va_copy`, `va_arg` and `va_end` to `core::intrinsics`

some questions:

- should these functions be `pub`?
- is a separate module justified?

r? `@RalfJung`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
4 participants
@folkertdev @rustbot @RalfJung @bors