Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tricky logic, these functions are much more informative than the manual implementations. They also catch subtle bugs:
is_multiple_of
often does not handle division by zerodiv_ceil
often does not consider overflowThe transformation is free for
is_multiple_of
if the divisor is compile-time known to be non-zero. Fordiv_ceil
there is a small cost to considering overflow. Here is some assembly https://godbolt.org/z/5zP8KaE1d.