Rollup of 9 pull requests #143601
Merged
Rollup of 9 pull requests #143601
+311
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering `&str::from("value")` do not suggest `&&str::from("value")`.
Fix rust-lang#132041.
Signed-off-by: Jonathan Brouwer <[email protected]>
`x86_64-unknown-netbsd` is Tier 2 with host tools, not Tier 3.
it doesn't need to return an `InterpResult`.
Fixes some sloppy editing on my part.
Do not suggest borrow that is already there in fully-qualified call
When encountering `&str::from("value")` do not suggest `&&str::from("value")`.
Fix rust-lang#132041.
awhile -> a while where appropriate
Fix the link in `rustdoc.md`
…ts, r=oli-obk Regression tests for repr ICEs Closes rust-lang#143522 Closes rust-lang#143479 Both issues were already (accidentally) fixed in this PR, but having the tests is nice rust-lang#143252 r? `@jdonszelmann`
…, r=fee1-dead Fix `x86_64-unknown-netbsd` platform support page `x86_64-unknown-netbsd` is Tier 2 with host tools, not Tier 3. cc `@he32.` r? compiler
…=fee1-dead Remove unused allow attrs These `#[allow]`s seem to be unused (at least according to `x check`, didn't run `x test` locally). Let's clean them up! 🧹
…r-on-block, r=bjorn3 `loop_match`: fix 'no terminator on block' tracking issue: rust-lang#132306 fixes rust-lang#143435 The argument `block` was not properly closed on an error path. r? `@bjorn3`
…l, r=RalfJung make `Machine::load_mir` infallible it doesn't need to return an `InterpResult`.
Fix missing words in future tracking issue Fixes some sloppy editing on my part.
rustbot
added
A-LLVM
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 2f8eeb2bba In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 2f8eeb2 (parent) -> a2d45f7 (this PR) Test differencesShow 20 test diffsStage 1
Stage 2
Additionally, 14 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a2d45f73c70d9dec57140c9412f83586eda895f8 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (a2d45f7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 465.909s -> 465.163s (-0.16%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustdoc.md#143438 (Fix the link inrustdoc.md)x86_64-unknown-netbsdplatform support page #143566 (Fixx86_64-unknown-netbsdplatform support page)loop_match: fix 'no terminator on block' #143583 (loop_match: fix 'no terminator on block')Machine::load_mirinfallible #143584 (makeMachine::load_mirinfallible)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup