-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Add Default
impls for Pin
ned Box
, Rc
, Arc
#143717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@bors2 try |
Add `Default` impls for `Pin`ned `Box`, `Rc`, `Arc` Fixes #143688. `@rustbot` label T-libs-api needs-fcp Also needs a crater run, as the `Box` impls could theoretically be breaking due to `#[fundamental]` (though a [cursory search](https://github.com/search?q=%2Fimpl%28%3C.*%3E%29%3F+Default+for+Pin%3C%2F+path%3A*.rs&type=code) suggests this is unlikely to cause issues).
@craterbot check |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
All spurious failures. “prepare-fail (112811)” seems not-great though. Looks like a lot of “no space left on device” errors? If an issue with crater is preventing a large proportion of the crates from being properly tested… |
Note that the prepare-fail category is a relatively recent change, they used to be categorized as error. Also prepare-fail results are included in the retry-regressed-list.txt |
@rfcbot merge |
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: Concerns:
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
Consider generalizing the impl<T> Default for Pin<Box<T>>
where
- T: Default
+ Box<T>: Default This would apply to types like @rfcbot concern Box<T>: Default |
Fixes #143688.
@rustbot label T-libs-api needs-fcp
Also needs a crater run, as the
Box
impls could theoretically be breaking due to#[fundamental]
(though a cursory search suggests this is unlikely to cause issues).