Skip to content

Constify trait aliases #144291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Constify trait aliases #144291

wants to merge 8 commits into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 22, 2025 •
edited by rustbot
Loading

Allow const trait Foo = Bar + [const] Baz; trait alias declarations. Their rules are the same as with super traits of const traits. So [const] Baz or const Baz is only required for [const] Foo or const Foo bounds respectively.

tracking issue #41517 (part of the general trait alias feature gate, but I can split it out into a separate const trait alias feature gate. I just assumed that const traits would stabilize before trait aliases, and we'd want to stabilize trait aliases together with const trait aliases at the same time)

r? @compiler-errors @fee1-dead

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2025

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

HIR ty lowering was modified

cc @fmease

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

nnethercote
nnethercote reviewed Jul 22, 2025
View reviewed changes
compiler/rustc_ast/src/ast.rs
static_assert_size!(Item, 144);
static_assert_size!(ItemKind, 80);
static_assert_size!(Item, 136);
static_assert_size!(ItemKind, 72);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blyxyas
Copy link
Member

blyxyas commented Jul 22, 2025

Clippy changes are approved.

ytmimi
ytmimi reviewed Jul 22, 2025
View reviewed changes
@bors
Copy link
Collaborator

bors commented Jul 23, 2025

☔ The latest upstream changes (presumably #143897) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the const_trait_alias branch 2 times, most recently from cb809b6 to 7508ac9 Compare July 23, 2025 14:30
@bors
Copy link
Collaborator

bors commented Jul 23, 2025

☔ The latest upstream changes (presumably #143843) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the const_trait_alias branch from 7508ac9 to 5d3eb69 Compare July 24, 2025 07:25
@bors
Copy link
Collaborator

bors commented Jul 27, 2025

☔ The latest upstream changes (presumably #143884) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors
Copy link
Member

r? fee1-dead or re-roll perhaps

@rustbot rustbot assigned fee1-dead and unassigned compiler-errors Sep 14, 2025
fee1-dead
fee1-dead requested changes Sep 16, 2025
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review because i didn't get enough time

Didn't look at the solver parts yet, will do later

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2025
@fee1-dead
Copy link
Member

The commits should probably be squashed.

@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 16, 2025

The commits should probably be squashed.

Hmm... I split them on purpose to only make atomic testable changes

@rustbot rustbot added the T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. label Sep 19, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@oli-obk oli-obk added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote left review comments

@ytmimi ytmimi ytmimi left review comments

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@oli-obk @rustbot @blyxyas @bors @compiler-errors @fee1-dead @rust-log-analyzer @nnethercote @ytmimi