-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Free disk space on Windows 2025 runners #144305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@bors try jobs=x86_64-msvc-1 |
Free disk space on Windows 2025 runners try-job: x86_64-msvc-1
e635015
to
9e95a28
Compare
I'll review this since I have a lot of context. r? marcoieni |
@bors try jobs=msvc,mingw |
Free disk space on Windows 2025 runners try-job: *msvc* try-job: *mingw*
96ed33f
to
7685c91
Compare
7685c91
to
5f662d5
Compare
@bors try jobs=x86_64-msvc-1 |
Free disk space on Windows 2025 runners try-job: x86_64-msvc-1
💔 Test failed (CI). Failed job:
|
@bors try jobs=x86_64-msvc-1 |
Free disk space on Windows 2025 runners try-job: x86_64-msvc-1
@bors try cancel |
Try build cancelled. Cancelled workflows: |
6616372
to
c88ff50
Compare
@bors try jobs=x86_64-msvc-1 |
Free disk space on Windows 2025 runners try-job: x86_64-msvc-1
@bors try cancel |
Try build was cancelled. It was not possible to cancel some workflows. |
c88ff50
to
25281c5
Compare
@bors try jobs=x86_64-msvc-1 |
Free disk space on Windows 2025 runners try-job: x86_64-msvc-1
25281c5
to
2054f20
Compare
'C:\Strawberry', 'C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk' | ||
|
||
foreach ($dir in $dirs) { | ||
Start-ThreadJob -InputObject $dir { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched to use threads as spawning a shell for each job is quite heavy weight on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to write this as a comment in the code if you think it's useful 👍
I tested this in https://github.com/marcoieni/actions-test and it works great! Can you squash the commit history? |
After that you squashed the commits and solved the last comment, let's try it one more time on all windows jobs to see how much space is left on every job |
Co-authored-by: Marco Ieni <[email protected]>
Squished! @bors try jobs=msvc,mingw |
Free disk space on Windows 2025 runners try-job: *msvc* try-job: *mingw*
try - dist-x86_64-mingw is the job with the lowest available disk space at 18G. So I think the script is removing enough disk space 🥳 Unfortunately in some jobs freeing the disk space takes up to 10 minutes. I think it's fine for now, but in the future we might want to try to make this step faster somehow 🤔 You can r=me once you clean the commit history 👍 |
I've managed to reduce the time deletion takes by:
It still takes 2-10 mins but that's not too bad.