Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past,
#[used]
had to appear in the top-level crate to have a consistent effect on the linker. This has been fixed a while ago for ELF with the introduction of thesymbols.o
file in #95604 (and more recently in Mach-O in #133832), which means that libraries can now implement the required workarounds themselves. This allows moving these#[used]
declarations out of ourmain.rs
.I have done so for
tikv-jemalloc-sys
in tikv/jemallocator#109 (and formimalloc
in purpleprotocol/mimalloc_rust#146, in case we want to experiment with switching to that one day), so waiting for those to land before this is ready.r? ghost
@rustbot blocked
try-job:
aarch64-gnu
try-job:
dist-aarch64-linux
try-job:
dist-x86_64-musl
try-job:
dist-x86_64-apple
try-job:
dist-aarch64-apple