loongarch: Mark partial intrinsics as safe #1874
Open
+4,020
−3,275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @folkertdev rustbot has assigned @folkertdev. Use |
folkertdev
reviewed
Jul 16, 2025
Comment on lines
+126
to
+128
| unsafe { | ||
| __dbar(IMM15); | ||
| } |
There was a problem hiding this comment.
nit: this would save 2 lines
Suggested change
| unsafe { | |
| __dbar(IMM15); | |
| } | |
| unsafe { __dbar(IMM15) }; |
Comment on lines
21
to
22
| let val: i32; | ||
| let tid: isize; |
There was a problem hiding this comment.
nit: this would also work
Suggested change
| let val: i32; | |
| let tid: isize; | |
| let (val, tid): (i32, isize); |
Comment on lines
+460
to
+463
| format!( | ||
| "pub {}fn {current_name}{fn_inputs} {fn_output}", | ||
| if is_mem { "unsafe " } else { "" } | ||
| ) |
There was a problem hiding this comment.
I understand this as a heuristic, but is it truly the case that only pointer reads/writes cause unsafety for these intrinsics?
| __lasx_xvslei_b(a, IMM_S5) | ||
| pub fn lasx_xvslei_b<const IMM_S5: i32>(a: v32i8) -> v32i8 { | ||
| unsafe { | ||
| static_assert_simm_bits!(IMM_S5, 5); |
There was a problem hiding this comment.
can the assert be lifted out of the unsafe block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.