intrinsic-test: Implemented DerefMut for ArmIntrinsicTest
#1878
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More details: 1. Moved the return type of IntrinsicType::from_c to Rust<Self, String> from Result<Box<Self>, String>
madhav-madhusoodanan
force-pushed
the
intrinsic-test-box-removing-and-more
branch
from
2b57ce1 to
c9c18ef
Compare
folkertdev
reviewed
Jul 16, 2025
Comment on lines
+18
to
+23
| impl DerefMut for ArmIntrinsicType { | ||
| fn deref_mut(&mut self) -> &mut Self::Target { | ||
| &mut self.0 | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this really worth it?
In general it is my impression that this code base is much too generic already (dyn, bunch of traits), but then only had one concrete implementation.
Deref is generally discouraged, why does it pull its weight here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context
This PR is part 2 of the changes that were originally made in the x86 extension PR #1814 for intrinsic-test, and is intended to unblock the speedup efforts that are being made in PRs #1856 , #1862 and #1863.