Skip to content

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Sep 8, 2025

cc @davidtwco (compiler lead)
cc @BoxyUwU (lead)

@tshepang
Copy link
Member Author

tshepang commented Sep 8, 2025

hm, ci fails

[WARN  rust_team::validate] couldn't perform checks relying on the Zulip API, some errors will not be detected
[WARN  rust_team::validate] cause: missing ZULIP_USER and/or ZULIP_TOKEN environment variables
[ERROR rust_team::validate] validation error: Access for the repo rust-lang/rust-forge is invalid
[ERROR rust_team::validate] validation error: Access for the repo rust-lang/rustc-dev-guide is invalid
[ERROR rust_team::validate] validation error: Access for the repo rust-lang/std-dev-guide is invalid

@jieyouxu
Copy link
Member

jieyouxu commented Sep 8, 2025

You need to update the team name references in the other repos as well:

wg-rustc-dev-guide = "write"

E.g. this needs to become the updated rustc-dev-guide subteam name, since you changed its name to drop the wg- prefix :)

@jieyouxu jieyouxu added needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. needs-team-lead-review This change requires a team/WG/PG lead to review. S-waiting-on-author Status: waiting on PR author labels Sep 8, 2025
Copy link

github-actions bot commented Sep 8, 2025

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Team Diffs:
    📝 Editing team 'rust-lang/all':
      Adding member 'amanjeev' with member role
      Adding member 'jyn514' with member role
      Adding member 'tshepang' with member role
    📝 Editing team 'rust-lang/inside-rust-reviewers':
      Adding member 'tshepang' with member role
    📝 Editing team 'rust-lang/leads':
      Adding member 'BoxyUwU' with member role
      Adding member 'tshepang' with member role
    ➕ Creating team:
      Org: rust-lang
      Name: rustc-dev-guide
      Description: Managed by the rust-lang/team repository.
      Privacy: closed
      Members:
        BoxyUwU: member
        JohnTitor: member
        amanjeev: member
        camelid: member
        jieyouxu: member
        jyn514: member
        tshepang: member
    ❌ Deleting team 'rust-lang/wg-rustc-dev-guide'
    💻 Repo Diffs:
    📝 Editing repo 'rust-lang/rust-forge':
      Permission Changes:
        Giving team 'rustc-dev-guide' maintain permission
        Removing team 'wg-rustc-dev-guide''s maintain permission 
    📝 Editing repo 'rust-lang/rustc-dev-guide':
      Permission Changes:
        Giving team 'rustc-dev-guide' maintain permission
        Removing team 'wg-rustc-dev-guide''s maintain permission 
    📝 Editing repo 'rust-lang/std-dev-guide':
      Permission Changes:
        Giving team 'rustc-dev-guide' write permission
        Removing team 'wg-rustc-dev-guide''s write permission 

@jieyouxu jieyouxu added S-waiting-on-team Status: waiting on team and removed S-waiting-on-author Status: waiting on PR author labels Sep 8, 2025
@jieyouxu jieyouxu removed the needs-team-lead-review This change requires a team/WG/PG lead to review. label Sep 10, 2025
@tshepang
Copy link
Member Author

fixed a merge conflict... should be ready now, given that rust-lang/rust-forge#956 has been approved

@jieyouxu jieyouxu added S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. and removed S-waiting-on-team Status: waiting on team labels Sep 27, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by parent team co-lead, WG co-lead is on board with team charter.

@jieyouxu jieyouxu added this pull request to the merge queue Sep 27, 2025
Merged via the queue into rust-lang:master with commit 2f06b2a Sep 27, 2025
3 checks passed
@tshepang tshepang deleted the wg-to-team branch September 27, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants