Skip to content

Expose internal pointer to AImage #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Expose internal pointer to AImage #470

wants to merge 2 commits into from

Conversation

@ShootingKing-AM
Copy link

  • needed for doing some direct operation on AImage ptr (maybe unsafe)
  • but anyways i think the library need not enforce AImage ptr to be hidden

@ShootingKing-AM
Expose internal pointer to AImage
1ea219d 
- needed for doing some direct operation on AImage ptr (maybe unsafe)
- but anyways i think the library need not enforce AImage ptr to be hidden
@ShootingKing-AM ShootingKing-AM marked this pull request as draft February 28, 2024 14:51
@ShootingKing-AM ShootingKing-AM marked this pull request as ready for review February 28, 2024 14:54
@MarijnS95
Copy link
Member

Before doing this, I'd like to consistenize the current split between fn as_ptr(&self) -> *mut T versus fn ptr(&self) -> NonNull<T>, as well as the documentation comments and safety constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShootingKing-AM @MarijnS95