vhost-device-rng: add support for standalone daemons #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fairly simple for the backend we just need to implement the specs message. The handling of GET/SET_STATUS is done by vhost internals. Signed-off-by: Alex Bennée <[email protected]>
Ablu
reviewed
Jul 19, 2023
| @@ -28,6 +28,7 @@ use vmm_sys_util::eventfd::{EventFd, EFD_NONBLOCK}; | |||
|
|
|||
| const QUEUE_SIZE: usize = 1024; | |||
| const NUM_QUEUES: usize = 1; | |||
| const VIRTIO_ID_RNG: u32 = 4; | |||
There was a problem hiding this comment.
Probably virtio-bindings should get extended with virtio_ids.h bindings?
There was a problem hiding this comment.
I did this for scsi recently, so I can propose a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fairly simple for the backend we just need to implement the specs message. The handling of GET/SET_STATUS is done by vhost internals.
Summary of the PR
This demonstrates the changes for enabling standalone at the daemon level.