Add [workspace.lints]
#547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, LGTM, just a couple of questions:
|
We need to update the CI rust to 1.74 first, otherwise the lints won't be picked up from the workspace.
Yeah, there might be a lot of errors. Incrementally sounds good! |
epilys
force-pushed
the
rust-1.74-lints
branch
2 times, most recently
from
399a656 to
9a3157d
Compare
epilys
changed the title
[workspace.lints] to manifest[workspace.lints]
epilys
requested review from
dorindabassey,
mz-pdm,
stsquad,
vireshk and
stefano-garzarella
as code owners
|
I was going through open PRs (github necromancy) to see if we could close something and decided to re-spin this. Only the first 2-3 commits are manual changes, the rest are mechanical clippy fixes (again...). Apologies for the noise in advance. |
stefano-garzarella
approved these changes
Aug 4, 2025
dorindabassey
approved these changes
Aug 4, 2025
dbg! does not use format specifiers and prints in stderr regardless of log output. Use log::debug! instead. Signed-off-by: Manos Pitsidianakis <[email protected]>
Replace type inferred raw pointer casts with .cast() method calls to make intent clearer. Signed-off-by: Manos Pitsidianakis <[email protected]>
casting usize as i32 might wrap around in 32-bit targets, we don't target them, but clippy complains. Signed-off-by: Manos Pitsidianakis <[email protected]>
Crates need to opt-in by setting:
[lints]
workspace = true
In their Cargo.toml file.
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
Signed-off-by: Manos Pitsidianakis <[email protected]>
stefano-garzarella
force-pushed
the
rust-1.74-lints
branch
from
17ea1ed to
bab70cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This PR enables all crates of the staging workspace to share lints. With 1.74 it is now possible to define them in
Cargo.toml.Note: In older versions you'll simply get a "warning: unused manifest key" when using cargo.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.