Use mio to replace Epoll #316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uran0sH
requested review from
Ablu,
epilys,
eryugey,
germag,
jiangliu,
sboeuf,
slp and
stefano-garzarella
as code owners
uran0sH
force-pushed
the
mio
branch
2 times, most recently
from
cbb223d to
138400e
Compare
germag
reviewed
Aug 19, 2025
uran0sH
force-pushed
the
mio
branch
3 times, most recently
from
2b19107 to
e53a34c
Compare
germag
reviewed
Aug 19, 2025
germag
reviewed
Aug 19, 2025
germag
reviewed
Aug 26, 2025
uran0sH
force-pushed
the
mio
branch
3 times, most recently
from
be19e30 to
158ca1d
Compare
uran0sH
force-pushed
the
mio
branch
2 times, most recently
from
44e7bb3 to
77ba627
Compare
germag
previously approved these changes
Sep 12, 2025
vhost-user-backend/src/handler.rs
Outdated
| let evt_idx = queues_mask.count_ones() - shifted_queues_mask.count_ones(); | ||
| self.handlers[thread_index] | ||
| .register_event(fd.as_raw_fd(), EventSet::IN, u64::from(evt_idx)) | ||
| .register_event(fd.as_raw_fd(), EventSet::IN, evt_idx as usize) |
There was a problem hiding this comment.
It's not to change now, but maybe we should change this type of casts to .try_into().map_err(...)?
There was a problem hiding this comment.
u32 to usize is safe? It is also safe to use the as statement directly?
|
this LGTM |
When register_event we pass in the value of u32/u64, so we don't need to convert it to u16 and then pass it to handle_event. Signed-off-by: Wenyu Huang <[email protected]>
We can safely use usize instead of u64, because normally we will not register a data that exceeds the size of usize Signed-off-by: Wenyu Huang <[email protected]>
Epoll is linux-specific. So we use mio, which is a cross-platform event notification, to replace Epoll. Signed-off-by: Wenyu Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Epoll is linux-specific. So we use mio, which is a cross-platform event notification, to replace Epoll.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.