-
Notifications
You must be signed in to change notification settings - Fork 21
Add IO manager support #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "coverage_score": 75.8, | ||
| "coverage_score": 79.9, | ||
| "exclude_path": "", | ||
| "crate_features": "" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,358 @@ | ||
| // Copyright © 2019 Intel Corporation. All Rights Reserved. | ||
| // SPDX-License-Identifier: (Apache-2.0 OR BSD-3-Clause) | ||
|
|
||
| //! System level device management. | ||
| //! | ||
| //! [IoManager](struct.IoManager.html) is respondsible for managing | ||
| //! all devices of virtual machine, registering IO resources callback, | ||
| //! unregistering devices and helping VM IO exit handling. | ||
| //! | ||
| //!VMM would be responsible for getting device resource request, ask | ||
| //! vm_allocator to allocate the resources, ask vm_device to register the | ||
| //! devices IO ranges, and finally set resources to virtual device. | ||
|
|
||
| use crate::resources::Resource; | ||
| use crate::{DeviceIo, IoAddress, IoSize}; | ||
|
|
||
| use std::cmp::{Ord, Ordering, PartialEq, PartialOrd}; | ||
| use std::collections::btree_map::BTreeMap; | ||
| use std::result; | ||
| use std::sync::Arc; | ||
|
|
||
| /// Error type for `IoManager` usage. | ||
| #[derive(Debug)] | ||
| pub enum Error { | ||
| /// The inserting device overlaps with a current device. | ||
| DeviceOverlap, | ||
| /// The device doesn't exist. | ||
| NoDevice, | ||
| } | ||
|
|
||
| /// Simplify the `Result` type. | ||
| pub type Result<T> = result::Result<T, Error>; | ||
|
|
||
| // Structure describing an IO range. | ||
| #[derive(Debug, Copy, Clone)] | ||
| struct IoRange { | ||
| base: IoAddress, | ||
| size: IoSize, | ||
| } | ||
|
|
||
| impl IoRange { | ||
| fn new_pio_range(base: u16, size: u16) -> Self { | ||
| IoRange { | ||
| base: IoAddress::Pio(base), | ||
| size: IoSize::Pio(size), | ||
| } | ||
| } | ||
| fn new_mmio_range(base: u64, size: u64) -> Self { | ||
| IoRange { | ||
| base: IoAddress::Mmio(base), | ||
| size: IoSize::Mmio(size), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl Eq for IoRange {} | ||
|
|
||
| impl PartialEq for IoRange { | ||
| fn eq(&self, other: &IoRange) -> bool { | ||
| self.base == other.base | ||
| } | ||
| } | ||
|
|
||
| impl Ord for IoRange { | ||
| fn cmp(&self, other: &IoRange) -> Ordering { | ||
| self.base.cmp(&other.base) | ||
| } | ||
| } | ||
|
|
||
| impl PartialOrd for IoRange { | ||
| fn partial_cmp(&self, other: &IoRange) -> Option<Ordering> { | ||
| self.base.partial_cmp(&other.base) | ||
| } | ||
| } | ||
|
|
||
| /// System IO manager serving for all devices management and VM exit handling. | ||
| #[derive(Default)] | ||
| pub struct IoManager { | ||
| /// Range mapping for VM exit pio operations. | ||
| pio_bus: BTreeMap<IoRange, Arc<dyn DeviceIo>>, | ||
| /// Range mapping for VM exit mmio operations. | ||
| mmio_bus: BTreeMap<IoRange, Arc<dyn DeviceIo>>, | ||
| } | ||
|
|
||
| impl IoManager { | ||
| /// Create an default IoManager with empty IO member. | ||
| pub fn new() -> Self { | ||
liujing2 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| IoManager::default() | ||
| } | ||
| /// Register a new device IO with its allocated resources. | ||
| /// VMM is responsible for providing the allocated resources to virtual device. | ||
| /// | ||
| /// # Arguments | ||
| /// | ||
| /// * `device`: device instance object to be registered | ||
| /// * `resources`: resources that this device owns, might include | ||
| /// port I/O and memory-mapped I/O ranges, irq number, etc. | ||
| pub fn register_device_io( | ||
| &mut self, | ||
| device: Arc<dyn DeviceIo>, | ||
| resources: &[Resource], | ||
| ) -> Result<()> { | ||
| // Register and mark device resources | ||
| // The resources addresses being registered are sucessfully allocated before. | ||
| for (idx, res) in resources.iter().enumerate() { | ||
| match *res { | ||
| Resource::PioAddressRange { base, size } => { | ||
| if self | ||
| .pio_bus | ||
| .insert(IoRange::new_pio_range(base, size), device.clone()) | ||
| .is_some() | ||
| { | ||
| // Unregister registered resources. | ||
| self.unregister_device_io(&resources[0..idx]) | ||
| .expect("failed to unregister devices"); | ||
|
|
||
| return Err(Error::DeviceOverlap); | ||
| } | ||
| } | ||
| Resource::MmioAddressRange { base, size } => { | ||
| if self | ||
| .mmio_bus | ||
| .insert(IoRange::new_mmio_range(base, size), device.clone()) | ||
| .is_some() | ||
| { | ||
| // Unregister registered resources. | ||
| self.unregister_device_io(&resources[0..idx]) | ||
| .expect("failed to unregister devices"); | ||
|
|
||
| return Err(Error::DeviceOverlap); | ||
| } | ||
| } | ||
| _ => continue, | ||
| } | ||
| } | ||
| Ok(()) | ||
| } | ||
|
|
||
| /// Unregister a device from `IoManager`, e.g. users specified removing. | ||
| /// VMM pre-fetches the resources e.g. dev.get_assigned_resources() | ||
| /// VMM is responsible for freeing the resources. | ||
| /// | ||
| /// # Arguments | ||
| /// | ||
| /// * `resources`: resources that this device owns, might include | ||
| /// port I/O and memory-mapped I/O ranges, irq number, etc. | ||
| pub fn unregister_device_io(&mut self, resources: &[Resource]) -> Result<()> { | ||
| for res in resources.iter() { | ||
| match *res { | ||
| Resource::PioAddressRange { base, size } => { | ||
| self.pio_bus.remove(&IoRange::new_pio_range(base, size)); | ||
| } | ||
| Resource::MmioAddressRange { base, size } => { | ||
| self.mmio_bus.remove(&IoRange::new_mmio_range(base, size)); | ||
| } | ||
| _ => continue, | ||
| } | ||
| } | ||
| Ok(()) | ||
| } | ||
|
|
||
| fn get_entry(&self, addr: IoAddress) -> Option<(&IoRange, &Arc<dyn DeviceIo>)> { | ||
| match addr { | ||
| IoAddress::Pio(a) => self | ||
| .pio_bus | ||
| .range(..=&IoRange::new_pio_range(a, 0)) | ||
| .nth_back(0), | ||
| IoAddress::Mmio(a) => self | ||
| .mmio_bus | ||
| .range(..=&IoRange::new_mmio_range(a, 0)) | ||
| .nth_back(0), | ||
| } | ||
| } | ||
|
|
||
| // Return the Device mapped `addr` and the base address. | ||
| fn get_device(&self, addr: IoAddress) -> Option<(&Arc<dyn DeviceIo>, IoAddress)> { | ||
| if let Some((range, dev)) = self.get_entry(addr) { | ||
| if (addr.raw_value() - range.base.raw_value()) < range.size.raw_value() { | ||
| return Some((dev, range.base)); | ||
| } | ||
| } | ||
| None | ||
| } | ||
|
|
||
| /// A helper function handling PIO read command during VM exit. | ||
| /// The virtual device itself provides mutable ability and thead-safe protection. | ||
| /// | ||
| /// Return error if failed to get the device. | ||
| pub fn pio_read(&self, addr: u16, data: &mut [u8]) -> Result<()> { | ||
| if let Some((device, base)) = self.get_device(IoAddress::Pio(addr)) { | ||
| device.read(base, IoAddress::Pio(addr - (base.raw_value() as u16)), data); | ||
| Ok(()) | ||
| } else { | ||
| Err(Error::NoDevice) | ||
| } | ||
| } | ||
|
|
||
| /// A helper function handling PIO write command during VM exit. | ||
| /// The virtual device itself provides mutable ability and thead-safe protection. | ||
| /// | ||
| /// Return error if failed to get the device. | ||
| pub fn pio_write(&self, addr: u16, data: &[u8]) -> Result<()> { | ||
liujing2 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if let Some((device, base)) = self.get_device(IoAddress::Pio(addr)) { | ||
| device.write(base, IoAddress::Pio(addr - (base.raw_value() as u16)), data); | ||
| Ok(()) | ||
| } else { | ||
| Err(Error::NoDevice) | ||
| } | ||
| } | ||
|
|
||
| /// A helper function handling MMIO read command during VM exit. | ||
| /// The virtual device itself provides mutable ability and thead-safe protection. | ||
| /// | ||
| /// Return error if failed to get the device. | ||
| pub fn mmio_read(&self, addr: u64, data: &mut [u8]) -> Result<()> { | ||
| if let Some((device, base)) = self.get_device(IoAddress::Mmio(addr)) { | ||
| device.read(base, IoAddress::Mmio(addr - base.raw_value()), data); | ||
| Ok(()) | ||
| } else { | ||
| Err(Error::NoDevice) | ||
| } | ||
| } | ||
|
|
||
| /// A helper function handling MMIO write command during VM exit. | ||
| /// The virtual device itself provides mutable ability and thead-safe protection. | ||
| /// | ||
| /// Return error if failed to get the device. | ||
| pub fn mmio_write(&self, addr: u64, data: &[u8]) -> Result<()> { | ||
| if let Some((device, base)) = self.get_device(IoAddress::Mmio(addr)) { | ||
| device.write(base, IoAddress::Mmio(addr - base.raw_value()), data); | ||
| Ok(()) | ||
| } else { | ||
| Err(Error::NoDevice) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
| use std::sync::Mutex; | ||
|
|
||
| const PIO_ADDRESS_SIZE: u16 = 4; | ||
| const PIO_ADDRESS_BASE: u16 = 0x40; | ||
| const MMIO_ADDRESS_SIZE: u64 = 0x8765_4321; | ||
| const MMIO_ADDRESS_BASE: u64 = 0x1234_5678; | ||
| const LEGACY_IRQ: u32 = 4; | ||
| const CONFIG_DATA: u32 = 0x1234; | ||
|
|
||
| struct DummyDevice { | ||
| config: Mutex<u32>, | ||
| } | ||
|
|
||
| impl DummyDevice { | ||
| fn new(config: u32) -> Self { | ||
| DummyDevice { | ||
| config: Mutex::new(config), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl DeviceIo for DummyDevice { | ||
| fn read(&self, _base: IoAddress, _offset: IoAddress, data: &mut [u8]) { | ||
| if data.len() > 4 { | ||
| return; | ||
| } | ||
| for (idx, iter) in data.iter_mut().enumerate() { | ||
| let config = self.config.lock().expect("failed to acquire lock"); | ||
| *iter = (*config >> (idx * 8) & 0xff) as u8; | ||
| } | ||
| } | ||
|
|
||
| fn write(&self, _base: IoAddress, _offset: IoAddress, data: &[u8]) { | ||
| let mut config = self.config.lock().expect("failed to acquire lock"); | ||
| *config = u32::from(data[0]) & 0xff; | ||
| } | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_register_unregister_device_io() { | ||
| let mut io_mgr = IoManager::new(); | ||
| let dummy = DummyDevice::new(0); | ||
| let dum = Arc::new(dummy); | ||
|
|
||
| let mut resource: Vec<Resource> = Vec::new(); | ||
| let mmio = Resource::MmioAddressRange { | ||
| base: MMIO_ADDRESS_BASE, | ||
| size: MMIO_ADDRESS_SIZE, | ||
| }; | ||
| let irq = Resource::LegacyIrq(LEGACY_IRQ); | ||
|
|
||
| resource.push(mmio); | ||
| resource.push(irq); | ||
|
|
||
| assert!(io_mgr.register_device_io(dum.clone(), &resource).is_ok()); | ||
| assert!(io_mgr.unregister_device_io(&resource).is_ok()) | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_mmio_read_write() { | ||
| let mut io_mgr: IoManager = Default::default(); | ||
| let dum = Arc::new(DummyDevice::new(CONFIG_DATA)); | ||
| let mut resource: Vec<Resource> = Vec::new(); | ||
|
|
||
| let mmio = Resource::MmioAddressRange { | ||
| base: MMIO_ADDRESS_BASE, | ||
| size: MMIO_ADDRESS_SIZE, | ||
| }; | ||
| resource.push(mmio); | ||
| assert!(io_mgr.register_device_io(dum.clone(), &resource).is_ok()); | ||
|
|
||
| let mut data = [0; 4]; | ||
| assert!(io_mgr.mmio_read(MMIO_ADDRESS_BASE, &mut data).is_ok()); | ||
| assert_eq!(data, [0x34, 0x12, 0, 0]); | ||
|
|
||
| assert!(io_mgr | ||
| .mmio_read(MMIO_ADDRESS_BASE + MMIO_ADDRESS_SIZE, &mut data) | ||
| .is_err()); | ||
|
|
||
| data = [0; 4]; | ||
| assert!(io_mgr.mmio_write(MMIO_ADDRESS_BASE, &data).is_ok()); | ||
| assert_eq!(*dum.config.lock().unwrap(), 0); | ||
|
|
||
| assert!(io_mgr | ||
| .mmio_write(MMIO_ADDRESS_BASE + MMIO_ADDRESS_SIZE, &data) | ||
| .is_err()); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_pio_read_write() { | ||
| let mut io_mgr: IoManager = Default::default(); | ||
| let dum = Arc::new(DummyDevice::new(CONFIG_DATA)); | ||
| let mut resource: Vec<Resource> = Vec::new(); | ||
|
|
||
| let pio = Resource::PioAddressRange { | ||
| base: PIO_ADDRESS_BASE, | ||
| size: PIO_ADDRESS_SIZE, | ||
| }; | ||
| resource.push(pio); | ||
| assert!(io_mgr.register_device_io(dum.clone(), &resource).is_ok()); | ||
|
|
||
| let mut data = [0; 4]; | ||
| assert!(io_mgr.pio_read(PIO_ADDRESS_BASE, &mut data).is_ok()); | ||
| assert_eq!(data, [0x34, 0x12, 0, 0]); | ||
|
|
||
| assert!(io_mgr | ||
| .pio_read(PIO_ADDRESS_BASE + PIO_ADDRESS_SIZE, &mut data) | ||
| .is_err()); | ||
|
|
||
| data = [0; 4]; | ||
| assert!(io_mgr.pio_write(PIO_ADDRESS_BASE, &data).is_ok()); | ||
| assert_eq!(*dum.config.lock().unwrap(), 0); | ||
|
|
||
| assert!(io_mgr | ||
| .pio_write(PIO_ADDRESS_BASE + PIO_ADDRESS_SIZE, &data) | ||
| .is_err()); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.