implement a no_std cargo feature
#69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strategy is as follows:
* anything that included `memmap` now also depends on `std`
* change all imports from `std::*` to either `core::*` or `::alloc::*`
as appropriate.
* `new_from_locale` accepts a CStr in `no_std` environments
* other load functions that depend on `std::fs` will not be included
in `no_std` environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strategy is as follows:
memmapnow also depends onstdstd::*to eithercore::*or::alloc::*as appropriate.new_from_localeaccepts a CStr inno_stdenvironmentsstd::fswill not be included inno_stdenvironmentsA
no_stdfeature could make the crate useful in embed environments, or otherwise places where one may want to keep memory usage to a minimum. In any case, I believe it would make the crate more flexible without being overly invasive, though I can understand if the developers have no interest in maintaining this.