Skip to content

Take updated dependencies #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 8, 2025
Merged

Take updated dependencies #579

merged 5 commits into from
Jul 8, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Jul 3, 2025

Notably this means rustls_platform_server_cert_verifier_with_provider can now return NULL. Avoiding that would mean using an out param and returning a rustls_result, but would be a major version bump. Thoughts?

(I checked and curl uses rustls_platform_server_cert_verifier and is therefore suitably fallible.)

@djc
Copy link
Member

djc commented Jul 3, 2025

Notably this means rustls_platform_server_cert_verifier_with_provider can now return NULL. Avoiding that would mean using an out param and returning a rustls_result, but would be a major version bump. Thoughts?

Probably not worth doing a major bump for? Do we have a deprecation mechanism here? Stick with 0.5 until rustls 0.24 comes out?

@ctz ctz force-pushed the jbp-maint branch 2 times, most recently from a8cc72c to 57b2fd6 Compare July 3, 2025 11:05
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not worth doing a major bump for?

Yeah, probably not, but the README's ABI stability claims mean consumers that take our .so need to treat every release as a major bump. I'd personally be inclined to wait for more changes to pile up in main to do any kind of release (or revisiting if there's an explicit request from downstream).

Do we have a deprecation mechanism here?

I think cbindgen supports translating #[deprecated] into __attribute__((deprecated)) annotations in the .h if that's what you meant 🤔

Handle fallible verifier creation.

Disable miri isolation as the existing tests now touch the
file system (to load root certs).
@ctz
Copy link
Member Author

ctz commented Jul 7, 2025

I think cbindgen supports translating #[deprecated] into __attribute__((deprecated)) annotations in the .h if that's what you meant 🤔

Added a commit to enable this. Then I've added rustls_platform_server_cert_verifier_try_with_provider (not loving that name, suggestions welcome) and used it as justification to make rustls_platform_server_cert_verifier_with_provider deprecated.

ctz added 2 commits July 7, 2025 19:29
This is `rustls_platform_server_cert_verifier_with_provider`
but with a more orderly way of reporting errors.

Mark `rustls_platform_server_cert_verifier_with_provider`
as deprecated.`
@ctz ctz merged commit abb1e40 into main Jul 8, 2025
56 checks passed
@ctz ctz deleted the jbp-maint branch July 8, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants