Skip to content

Conversation

djc
Copy link
Member

@djc djc commented Aug 31, 2025

Intended to address the use case indicated by

@sgrams would this help you?

@djc djc requested review from cpu and ctz August 31, 2025 09:41
Copy link

codecov bot commented Aug 31, 2025

Codecov Report

❌ Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.45%. Comparing base (4a03b51) to head (db64a7a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/verify_cert.rs 94.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   97.52%   97.45%   -0.07%     
==========================================
  Files          20       20              
  Lines        4081     4088       +7     
==========================================
+ Hits         3980     3984       +4     
- Misses        101      104       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, though it would be good to confirm it can replace #372 from the perspective of that user before we cut a release with the new API baked in.

@djc djc added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 57fa975 Sep 3, 2025
38 of 40 checks passed
@djc djc deleted the check-eku branch September 3, 2025 07:24
@sgrams
Copy link

sgrams commented Sep 15, 2025

Hi, thank you, I think this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants