Skip to content

feat: update rust edition to 2024 and change asm! to naked_asm! #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2025

Conversation

guttatus
Copy link
Contributor

@guttatus guttatus commented Feb 8, 2025

This pull request implements the following features.

  • Update rust edition to 2024
  • Use naked_asm! instead of asm! in all #[naked] functions, and removes options(noreturn) which is implicit with naked_asm!

Copy link
Member

@luojia65 luojia65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in the future we can define edition in workspace level and use edition.workspace = true.

@YdrMaster YdrMaster merged commit 8cbb773 into rustsbi:main Feb 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants