Add netcore3.1 support #14
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BeginItemCollectionCore 1.0.9 links against netcoreapp2.0 and has a package reference to Microsoft.AspNetCore.All version 2.0.9. The new 1.1.0 net5.0 with a framework reference to Microsoft.AspNetCore.App.
That means if you have a netcoreapp3.1 MVC app with a nuget package reference to BeginItemCollectionCore, you get the 2.0.9 version. It brings with it the Microsoft.AspNetCore.App package version 2.0.9 which includes:
This creates a problem that prevents the application from compiling if you are using Redis caching because the netcoreapp3.1 Microsoft.NET.Sdk.Web contains a reference to new libraries for Redis caching.
Both sets of libraries include the
StackExchange.Redis.ConnectionMultiplexer
type which causes the compilation to fail:I think the best solution is to build add a netcoreapp3.1 build artifact to your nuget package.
I've modified your csproj files to target both netcoreapp3.1 and net5.0. This completely solves the issue for me.