-
Notifications
You must be signed in to change notification settings - Fork 22
Feature makeindex #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
added option args, falling back to default if not passed.
prevent child process from stalling
merge master in
merge master back
options.makeindex and options.indexStyle
Hey @urshofer, thanks a lot for this PR! This is interesting and would probably be a cool feature to add. Would you be able to share a small example of a Also, currently I wouldn't be able to accept this PR due to the usage of I'd be very happy to work together on this with you if you wouldn't mind sharing an example so that I can test it out a bit. Let me know if you have any questions/comments on it! :) |
Hi Saad you're right - spawnSync is not elegant but indeed the passes have to wait for makeindex to complete.
Using callbacks would result in a litte bit more and duplicate code, and nested async calls are sometimes hard to read. Urs PS: I'm quite busy right now but this would be kind of a minimal example:
This should result in something like this: |
Sorry for the delay, I've been a bit busy! I'll be able to check this out within a few days, and I'll let you know if I have any feedback. Thanks for the example! |
I've implemented makeindex. It works for my needs. There are two options, see the readme file. Since I'm using makeindex in a german environment, I use the -g option. It can be omitted or made optional.