Skip to content

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 9, 2025

PHP 8.5 works, so use it in CI

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.18%. Comparing base (2ad0fed) to head (37d69f3).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #139      +/-   ##
============================================
- Coverage     99.21%   99.18%   -0.03%     
  Complexity      111      111              
============================================
  Files             7        7              
  Lines           380      370      -10     
============================================
- Hits            377      367      -10     
  Misses            3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phil-davis phil-davis marked this pull request as draft September 9, 2025 10:55
@phil-davis
Copy link
Contributor Author

That works OK. I will leave this to merge after PHP 8.5 is officially released in Nov 2025.

https://wiki.php.net/todo/php85

@phil-davis phil-davis marked this pull request as ready for review December 1, 2025 09:35
@phil-davis phil-davis merged commit 186b5d9 into sabre-io:master Dec 1, 2025
8 of 9 checks passed
@phil-davis phil-davis deleted the php-8.5 branch December 1, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant