Add Batyrev's smooth fano toric varieties of dim 3 and 4 to toric library #40270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 90a8871; changes) is ready! 🎉 |
|
You need to add the new file to the meson build system, probably to |
|
I have done it for you. Beware to pull the branch before doing further work. |
|
you need to fix the linter (see Lint in the checks) and also |
thanks a lot for pointing this out and fixing it! |
Thanks! I will make sure to take care of this after a relative complete version of my work. |
…with picard number 3
local-ring
force-pushed
the
generating-toric-varieties
branch
from
303536a to
5b42c65
Compare
local-ring
changed the title
|
you have a meson issue, as you add another new file |
…me methods from derived category class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementation of Batyrev's paper in 1999 on construction of smooth toric Fano 3-fold/4-fold to enrich the current library of the toric varieties, which can be served as the playground for derived categories in the future.
We borrow the ingredient from the database of the smooth reflexive lattice polytopes.
Part of #40269
cc: @tscrim
📝 Checklist
⌛ Dependencies
#40416: we use the the class as the base class for smooth Fano toric varieties