Fix-40738: Fix ExteriorAlgebra multiplication to preserve symbolic coefficients #40741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40738
Problem:
When multiplying elements of an
ExteriorAlgebra
over the Symbolic Ring (SR
), symbolic coefficients were being dropped in certain cases, such as in the product(x*a)*(y*b)
.Solution:
This PR corrects the multiplication logic in
ExteriorAlgebraElement._mul_
by:R = self.base_ring()
at the start of the method.R(cl) * R(cr)
) before they are multiplied.This ensures that symbolic multiplication is handled correctly, preserving all coefficients as expected.
### Checklist
### Hourglass