Skip to content

Check sagemath kernel integrity robustly #41132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 11, 2025
Merged

Check sagemath kernel integrity robustly #41132

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3dde262
Make checking robust
kwankyu Nov 4, 2025
3fa454a
Go without quotation marks
kwankyu Nov 4, 2025
053f5ca
Soothe ruff
kwankyu Nov 4, 2025
cf58a7b
Add a period at the end of message
kwankyu Nov 5, 2025
0b3f7b9
Deal with the case that no kernel executable is available
kwankyu Nov 9, 2025
c157057
Add missing return statement
kwankyu Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/sage/repl/ipython_kernel/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,15 +257,23 @@ def check(cls):
try:
spec = get_kernel_spec(ident)
except NoSuchKernel:
warnings.warn(f'no kernel named {ident} is accessible; '
warnings.warn(f'No kernel named {ident} is accessible; '
'check your Jupyter configuration '
'(see https://docs.jupyter.org/en/latest/use/jupyter-directories.html)')
'(see https://docs.jupyter.org/en/latest/use/jupyter-directories.html).')
else:
import sys
import shutil
from pathlib import Path
if Path(spec.argv[0]).resolve() != Path(os.path.join(SAGE_VENV, 'bin', 'sage')).resolve():
warnings.warn(f'the kernel named {ident} does not seem to correspond to this '
kernel_executable = shutil.which(spec.argv[0])
if not kernel_executable:
warnings.warn(f'The kernel named {ident} does not seem to be runnable; '
'check your Jupyter configuration '
'(see https://docs.jupyter.org/en/latest/use/jupyter-directories.html).')
return
if Path(kernel_executable).resolve() != Path(sys.executable).resolve():
warnings.warn(f'The kernel named {ident} does not seem to correspond to this '
'installation of SageMath; check your Jupyter configuration '
'(see https://docs.jupyter.org/en/latest/use/jupyter-directories.html)')
'(see https://docs.jupyter.org/en/latest/use/jupyter-directories.html).')


def have_prerequisites(debug=True) -> bool:
Expand Down
Loading