Conat integrated cluster support #8388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it is so helpful for unit tests
…st across a supercluster
…attern goes away, so it doesn't grow unbounded over time
- I haven't even really decided on the semantics of this yet, so this is just a first little sanity check
… exposes a blocker bug in persist/cluster2.test.ts
…odes; rewrite metrics recorder in typescript
- everything doesn't work, and we'll have to get way to low level; also no evidence at all that this is needed, and extensive evidence it is NOT needed
- this doesn't fix it, but has a key comment about one of the steps needed. Basically, some of the code around core-stream doesn't take the fact that messages can be dropped under load seriously enough, etc.
… under heavy load
…ed and there's a warning message - this was causing a lot of trouble for testing, but is very unlikely for a client in the wild, since their connection usually equals the lifetime of the thing
…to conat-supercluster
- this was causing excessive cpu usage when testing on kucalc -- super glad to found it before release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want this to easily scale to an order of magnitude more users than we have now, so better write it now when it is fun rather than later when it's stressful!
The goal here is basically to replace the "cluster adapter" from socketio with something similar that (1) is much more dynamic, (2) is more scalable (don't broadcast every message to every node), and (3) utilizes conat's built in ability to manage and work with distributed streams (something even redis doesn't do).