-
Notifications
You must be signed in to change notification settings - Fork 226
new architecture #8453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
williamstein
wants to merge
486
commits into
master
Choose a base branch
from
fs2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
new architecture #8453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t tests); add option to disable nsjail entirely
- i don't use it - it is broken right now -- https://github.com/sagemathinc/cocalc/actions/runs/16836511668/job/47698086128
… file) - doesn't work properly yet if frontend that starts computation goes away
…ld be done using CSS (and is trivial to do that way), and was horribly broken
… but I broke this in the rewrite)
…g on a server with a non-UTC clock - this was a longstanding issue with cocalc-docker / onprem - not doing this would lead to very subtle issues/bugs, which I noticed when fixing unit tests for the server package - this code makes it so NOW() is interpreted as UTC and the internal fields that are without a timezone also are interpreted as UTC when reading out from the database... according to GPT-5.
- I considered a bunch of options and hacks. - Using a spool directory seems like the most flexible and robust overall, and easiest to do without worrying about paths lengths and other subtle issues - It works fine with any terminal multiplexer like TMUX - The code's nice but NOT simple... because it was half written by GPT5. But this is exactly the sort of thing GPT5 is good at :-). - MOTIVATION: i wanted 'open foo' to work in tmux, and it randomly stopped working due to changes in tmux. This approach is just much more reliable.
…r_id, but with generic fallback still
… "compute servers"
…entity" - this is cleaner code and will also be pretty flexible...
…e v20. (and I'm using v24 for dev now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.