feat: typescript generics #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netail
force-pushed
the
feat/typescript-generics
branch
2 times, most recently
from
63af615 to
c38427e
Compare
|
Thanks! -- it seems to be failing tests. |
Yup, a few things are left to fix. But off to bed, hence the draft :) |
|
Thanks again! |
Netail
force-pushed
the
feat/typescript-generics
branch
3 times, most recently
from
08151fd to
84566ce
Compare
Netail
force-pushed
the
feat/typescript-generics
branch
5 times, most recently
from
d7e427e to
b43b2af
Compare
Netail
force-pushed
the
feat/typescript-generics
branch
from
b43b2af to
5659027
Compare
|
@williamstein PR should be ready, but the migration from jest to vitest broke some cicd |
|
I'll fix the CI/CD now. |
|
This looks good to me, passes now, and is [email protected]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support incoming message & server response generics
Fixes # #19