Skip to content

Conversation

ymazzer
Copy link
Contributor

@ymazzer ymazzer commented Oct 24, 2024

A pull request including the fix for the #3010 issue as fixed in the PR #3016 but isolated to make it easier to merge.

@ymazzer
Copy link
Contributor Author

ymazzer commented Oct 24, 2024

@sachilles this issue is quite blocking, is it possible for you to include it in the coming update for 17.5.1?

Copy link
Collaborator

@sachilles sachilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sachilles
Copy link
Collaborator

@ymazzer Of course, I'll merge your PR once the CI finished correctly. The problem an ist solution seems to bi quite general. Do you think that we should backport your PR to the last 2 supported versions (i.e. 17.4.x and 17.3.x)?

@sachilles sachilles merged commit 8ce157e into sameersbn:master Oct 25, 2024
3 checks passed
@ymazzer
Copy link
Contributor Author

ymazzer commented Oct 28, 2024

@ymazzer Of course, I'll merge your PR once the CI finished correctly. The problem an ist solution seems to bi quite general. Do you think that we should backport your PR to the last 2 supported versions (i.e. 17.4.x and 17.3.x)?

@sachilles at least 17.4.x, since the problem was present in 17.4.x, I didn't tested it in 17.3.x.

This is a hack to fix the issue, btw this has to be reworked correctly for the coming 17.7 with openssl3

sachilles added a commit to sachilles/docker-gitlab that referenced this pull request May 15, 2025
kkimurak pushed a commit to kkimurak/docker-gitlab that referenced this pull request May 20, 2025
- This hack was introduced by  sameersbn#3027 in order to fix sameersbn#3010.

(cherry picked from commit 3d07804)
kkimurak pushed a commit to kkimurak/docker-gitlab that referenced this pull request Jun 16, 2025
- This hack was introduced by  sameersbn#3027 in order to fix sameersbn#3010.

(cherry picked from commit 3d07804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants