This repository was archived by the owner on Feb 15, 2023. It is now read-only.
go schemabuilder: apply object options even if object is already regi… #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stered Currently, when we define an object more than once within a single gql schema, we will ignore any options defined after the first registration (which is pseudo-randomly determined when the schema is built). We want to be able to apply options for every time we register an object, so we can have some regulations on object option code. Currently, the only use for object options are for federation, where we use it to define a FetchObjectFromKeys method. Ignoring options on repeat registrations means a lot of code gets dropped. We want to ensure that FetchObjectFromKeys only gets defined once per gql server.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we define an object more than once within a single gql schema, we will ignore any options defined after the first registration (which is pseudo-randomly determined when the schema is built). We want to be able to apply options for every time we register an object, so we can have some regulations on object option code.
Currently, the only use for object options are for federation, where we use it to define a FetchObjectFromKeys method. Ignoring options on repeat registrations means a lot of code gets dropped. We want to ensure that FetchObjectFromKeys only gets defined once per gql server.