Ensure Consistency of Global Parameter Indices. #612
+214
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to from_vector will result in an unpassable param vec.
rileyjmurray
requested changes
Jul 23, 2025
There was a problem hiding this comment.
Thanks for this fix, and for writing the tests!
I have two requests.
- Please make the tests instance methods of a new class, TestRebuildParamvec, that subclasses unittest.TestCase.
- Please update the PR opening comment to explain the purpose of the PR. You, me, and the other pyGSTi devs will know the purpose for the near future, but we'll inevitably forget.
I'll note that a search through the pyGSTi codebase shows that ModelMember.shift_gpindices is called only in two places: once recursively in shift_gpindices itself, and once in OpModel._rebuild_paramvec. The latter wasn't passing in any value for the "memo" argument in ModelMember.shift_gpindices.
|
We'll also need to track down what is going on with the failing unit tests. These look substantive, so there may be some unexpected consequences being caught. Do these fail locally on your system? |
nkoskelo
changed the title
…y of the parameter vector and not a view of the parameter vector.
Add in a number of patches/workarounds related to parameter-integrity checks when using interposers.
Add a debug option to print out diagnostics for _clean_paramvec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global parameter indices recorded by a layer with only one non-idle gate should be the same as those recorded by the gate itself.
Whenever a new parameterized object is added to a model, there is a possibility that we need to shift the global parameter indices stored by each object within the model.
A call to
shift_gpindiceswill now track which changes have already been made.